[PATCH] D144544: [OpenMP] Improve LIT tests on composite target constructs
Animesh Kumar via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 22 21:05:19 PST 2023
animeshk-amd added a comment.
In D144544#4144563 <https://reviews.llvm.org/D144544#4144563>, @jdoerfert wrote:
> I guess this is fine. We should try to run V&V tests, this is really just checking if we generate (some) code.
Thanks for accepting.
Right. By running V&V tests, do you mean to suggest that these combinations of directives should instead be tested using execution tests which are usually run using `ninja check-openmp` ? For example, tests in the "openmp/libomptarget/test/" directory.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144544/new/
https://reviews.llvm.org/D144544
More information about the cfe-commits
mailing list