[PATCH] D143210: [PowerPC] Include vector bool and pixel when emitting lax warning

Kamau Bridgeman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 22 08:50:55 PST 2023


kamaub added a comment.

We may also need an associated test case for the changed behaviour for using `areCompatibleVectorTypes()` instead of `areSameVectorElemTypes()`.
The test coverage should display when warnings are emitted now that we account for vector bool, vector pixel and type qualifiers.



================
Comment at: clang/lib/Sema/SemaExpr.cpp:9861
           isLaxVectorConversion(RHSType, LHSType)) {
-        if (VecType->getVectorKind() == VectorType::AltiVecVector)
+        if (VecType->getVectorKind() == VectorType::AltiVecVector ||
+            VecType->getVectorKind() == VectorType::AltiVecBool ||
----------------
Is there test coverage for these addition to the if condition?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143210/new/

https://reviews.llvm.org/D143210



More information about the cfe-commits mailing list