[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

DonĂ¡t Nagy via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 22 03:03:34 PST 2023


donat.nagy added a comment.

Note that the Debian x64 test failure is from the unit test

  TEST(ClangdServer, MemoryUsageTest) {
    MockFS FS;
    MockCompilationDatabase CDB;
    ClangdServer Server(CDB, FS, ClangdServer::optsForTest());
  
    auto FooCpp = testPath("foo.cpp");
    Server.addDocument(FooCpp, "");
    ASSERT_TRUE(Server.blockUntilIdleForTest());  // THIS ASSERTION FAILED
  
    llvm::BumpPtrAllocator Alloc;
    MemoryTree MT(&Alloc);
    Server.profile(MT);
    ASSERT_TRUE(MT.children().count("tuscheduler"));
    EXPECT_TRUE(MT.child("tuscheduler").children().count(FooCpp));
  }

(from clang-tools-extra/clangd/unittests/ClangdTests.cpp lines 1244-1258). I'm not familiar with this area but it's unrelated to the commit and words like "scheduler" and "block until idle" suggest that this unit test is not entirely deterministic, so it's plausible that its failure is not connected to the commit under review. Is there a possibility to retrigger test execution to see whether this error reappears on another run?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144273/new/

https://reviews.llvm.org/D144273



More information about the cfe-commits mailing list