[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:4218-4223
 defm openmp_implicit_rpath: BoolFOption<"openmp-implicit-rpath",
   LangOpts<"OpenMP">,
-  DefaultTrue,
+  DefaultFalse,
   PosFlag<SetTrue, [], "Set rpath on OpenMP executables">,
   NegFlag<SetFalse>,
   BothFlags<[NoArgumentUnused]>>;
----------------
yaxunl wrote:
> I am wondering whether this option can be aliased to `--offload-add-rpath`, which seems to have the same purpose. (https://reviews.llvm.org/D136854)
It can be aliased to `--[no-]offload-add-rpath`, but I think it probably makes sense to drop this option completely. This patch as-is is useful for backporting into 16.x.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143306/new/

https://reviews.llvm.org/D143306