[PATCH] D144454: Add builtin for llvm set rounding
Andy Kaylor via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 21 10:15:28 PST 2023
andrew.w.kaylor accepted this revision.
andrew.w.kaylor added a comment.
This revision is now accepted and ready to land.
This looks good to me. I'm adding @rjmccall as a reviewer to make sure someone with front end expertise sees this.
There seems to be a potential type mismatch between the intrinsic and the builtin in the case of __builtin_flt_rounds(). Based on D24461 <https://reviews.llvm.org/D24461>, I wonder if that's a target-specific difference. I'm not sure if a similar issue exists in this case since we aren't copying a gcc builtin.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144454/new/
https://reviews.llvm.org/D144454
More information about the cfe-commits
mailing list