[PATCH] D144495: [NFC][clang] Refine tests by adding `:` to checks

Mariya Podchishchaeva via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 21 08:04:15 PST 2023


Fznamznon created this revision.
Herald added a subscriber: arphaman.
Herald added a project: All.
Fznamznon requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

The tests can fail if wokring directory where the tests were launched
has a `error` substring in its path.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D144495

Files:
  clang/test/Driver/unknown-std.S
  clang/test/Index/allow-editor-placeholders.cpp
  clang/test/VFS/real-path-found-first.m
  clang/test/VFS/vfsroot-include.c


Index: clang/test/VFS/vfsroot-include.c
===================================================================
--- clang/test/VFS/vfsroot-include.c
+++ clang/test/VFS/vfsroot-include.c
@@ -13,4 +13,4 @@
 #include "actual_header.h"
 // CHECK: fatal error: 'actual_header.h' file not found
 // CHECK: 1 error generated.
-// CHECK-NOT: error
+// CHECK-NOT: error:
Index: clang/test/VFS/real-path-found-first.m
===================================================================
--- clang/test/VFS/real-path-found-first.m
+++ clang/test/VFS/real-path-found-first.m
@@ -39,7 +39,7 @@
 // RUN:     -ivfsoverlay %t.yaml -fsyntax-only -Rmodule-include-translation \
 // RUN:     -Werror=non-modular-include-in-framework-module | FileCheck %s
 // CHECK: warning: treating
-// CHECK-NOT: error
+// CHECK-NOT: error:
 
 // With a VFS-mapped module map file
 // RUN: mv %t/SomeFramework.framework/Modules/module.modulemap %t/hide_module.map
Index: clang/test/Index/allow-editor-placeholders.cpp
===================================================================
--- clang/test/Index/allow-editor-placeholders.cpp
+++ clang/test/Index/allow-editor-placeholders.cpp
@@ -2,4 +2,4 @@
 
 <#placeholder#>;
 
-// CHECK-NOT: error
+// CHECK-NOT: error:
Index: clang/test/Driver/unknown-std.S
===================================================================
--- clang/test/Driver/unknown-std.S
+++ clang/test/Driver/unknown-std.S
@@ -1,2 +1,2 @@
 // RUN: %clang -std=c++11 %s -E -o /dev/null 2>&1 | FileCheck %s --allow-empty
-// CHECK-NOT: error
+// CHECK-NOT: error:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144495.499185.patch
Type: text/x-patch
Size: 1549 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230221/a83e131b/attachment.bin>


More information about the cfe-commits mailing list