[PATCH] D141950: [NFC] Use find_last_of when seraching for code in getRawCommentForDeclNoCacheImpl

Kugan Vivekanandarajah via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 21 07:58:59 PST 2023


kuganv added a comment.

In D141950#4141455 <https://reviews.llvm.org/D141950#4141455>, @aaron.ballman wrote:

> LGTM! You should probably put "NFC" into the patch title when landing the changes though, so it's more clear as to why there's no test coverage.
>
> Do you think this warrants adding a release note to let users know about the performance improvement?

Thanks for the review. I have updated the title with NFC. This may not be significant enough to require update on release notes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141950/new/

https://reviews.llvm.org/D141950



More information about the cfe-commits mailing list