[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

David Rector via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 20 10:28:38 PST 2023


davrec added inline comments.


================
Comment at: clang/lib/Lex/Lexer.cpp:3630-3632
     do {
-      ++CurPtr;
-    } while (isHorizontalWhitespace(*CurPtr));
+      ++CurOffset;
+    } while (isHorizontalWhitespace(BufferStart[CurOffset]));
----------------
davrec wrote:
> ```
> for (isHorizontalWhitespace(BufferStart[++CurOffset]);;)
>   ;
> ```
> might save a few instructions?  Worth trying since this function is the main perf-critical one.
^ Ignore, erroneous :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143142/new/

https://reviews.llvm.org/D143142



More information about the cfe-commits mailing list