[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

Mon Feb 20 03:11:59 PST 2023

cor3ntin added a comment.

Thanks for working on this issue.
I don't feel confident commenting on this patch's approach (I think @erichkeane is your best bet), but the small typo does make a pretty big difference here!

================
Comment at: clang/include/clang/AST/DeclCXX.h:1549
   ///
+  /// \param LookupIndependent whether look up independent types.
+  ///
----------------

================
Comment at: clang/include/clang/AST/DeclCXX.h:1553
+  bool isDerivedFrom(const CXXRecordDecl *Base,
+                     bool LookupIndependent = false) const;

----------------
Ditto in the rest of the patch

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143840/new/

https://reviews.llvm.org/D143840