[PATCH] D143725: [llvm-objdump][ARM] support --symbolize-operands for ARM/ELF

Mon Feb 20 00:44:21 PST 2023

jhenderson added inline comments.

================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1145
+  // So far only supports ARM/Thumb, PowerPC and X86.
+  Triple triple = STI->getTargetTriple();
+  if (!triple.isPPC() && !triple.isX86() && !triple.isARM() &&
----------------
covanam wrote:
> Esme wrote:
> > Please capitalize the first letter of variable names.
> Sorry I am newcomer. clang-format didn't say anything, so I thought this is okay.
> Will be fixed. Same for the other one.
clang-format is only for formatting. It won't do things like variable name styles. You may want to look into clang-tidy which does a lot more. Also, make sure you've fully read and digested the [[ https://llvm.org/docs/CodingStandards.html | LLVM coding standards ]].

FWIW, here you can't simply do `triple` -> `Triple`, since `Triple` is a type. You probably can use `TargetTriple` or something along those lines.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143725/new/

https://reviews.llvm.org/D143725