[PATCH] D144011: [clang]Fix warning for signed conversion on LP64
Yaxun Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 17 19:52:13 PST 2023
yaxunl marked an inline comment as done.
yaxunl added inline comments.
================
Comment at: clang/lib/Sema/SemaChecking.cpp:14296
+ if (SourceBT && SourceBT->isInteger() && TargetBT &&
+ TargetBT->isInteger() &&
----------------
MaskRay wrote:
> Consider adding an example when this condition triggers to help understanding, e.g. `long t2 = 1LL << x;` on LP64 systems.
will do when committing
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144011/new/
https://reviews.llvm.org/D144011
More information about the cfe-commits
mailing list