[PATCH] D144157: Add 128-bit integer support to enum element

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 17 19:28:11 PST 2023


MaskRay added inline comments.


================
Comment at: clang/test/CodeGen/enum3.c:1
+// RUN: %clang_cc1 -triple x86_64-linux-gnu %s -debug-info-kind=limited -emit-llvm -o - | FileCheck %s
+
----------------
We don't need a new test file. Reusing can improve test discoverability and readability for this test.

I think this test needs to show how the global variable `v`'s value is changed by the `__uint128_t` enum, which enum2.c may lack (a problem of many old tests).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144157/new/

https://reviews.llvm.org/D144157



More information about the cfe-commits mailing list