[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

[Corentin Jabot via Phabricator via cfe-commits]

cor3ntin added inline comments.


================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16806
+    bool InTemplateDefinition =
+        getLangOpts().CPlusPlus && CurContext->isDependentContext();
+
----------------
erichkeane wrote:
> CplusPlus check is now not really beneficial?  I'm not sure how much it matters now though that these are both just bit-loads.
isDependentContext still does a bunch of work, recursively. I think we should keep it!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144285/new/

https://reviews.llvm.org/D144285