[PATCH] D143301: [flang] Handle unsupported warning flags

Andrzej Warzynski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 17 08:32:14 PST 2023


awarzynski added a comment.

@elmcdonough , let me rephrase this (should've been clearer before, sorry):

> One thing that's not clear to me - how come "-Wextra" is not treated as an error and "-Wblah" is?

Where's the logic that makes sure that `-Wextra` (and other flags that you redefine here) is reported as unused? That's not clear from this definition:

  multiclass FlangIgnoredDiagOpt<string name> {
    def unsupported_warning_w#NAME : Flag<["-", "--"], "W"#name>, Group<flang_ignored_w_Group>;
  }

In particular, I don't see anything that would check whether a particular option is in this group: `flang_ignored_w_Group`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143301/new/

https://reviews.llvm.org/D143301



More information about the cfe-commits mailing list