[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

[Whisperity via Phabricator via cfe-commits]

whisperity added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/cert/dcl58-cpp.cpp:3
+// RUN: %check_clang_tidy -std=c++17-or-later %s cert-dcl58-cpp %t -- -- -I %clang_tidy_headers -target aarch64
+// RUN: %check_clang_tidy -std=c++17-or-later %s cert-dcl58-cpp %t -- -- -I %clang_tidy_headers -target arm
+
----------------
balazske wrote:
> I am not sure if these platform specific should be added. A problem was discovered on this platform but this could be true for all other tests.
I agree because there might be a case that some buildbot running the tests won't have these targets. If we really need to explicitly test something related to these targets, perhaps they should go into a separate file, and have a check-prefix. Or the expectation is that things work in the same way across all three platforms?


================
Comment at: clang/docs/ReleaseNotes.rst:63
   `Issue 60344 <https://github.com/llvm/llvm-project/issues/60344>`_.
+- Fix importing of va_list types and declarations.
 
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142822/new/

https://reviews.llvm.org/D142822