[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 16 14:19:45 PST 2023


shafik added inline comments.


================
Comment at: clang/lib/Sema/TreeTransform.h:4572
                : Sema::ExpressionEvaluationContext::ConstantEvaluated,
-        /*LambdaContextDecl=*/nullptr, /*ExprContext=*/
+        Sema::ReuseLambdaContextDecl, /*ExprContext=*/
         Sema::ExpressionEvaluationContextRecord::EK_TemplateArgument);
----------------
Not for this PR but I am looking at other place we use `EnterExpressionEvaluationContext` and it is not obvious to me when we should be using `Sema::ReuseLambdaContextDecl` or not. So might be worth looking at other uses as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144192/new/

https://reviews.llvm.org/D144192



More information about the cfe-commits mailing list