[PATCH] D143509: Move the BySpelling map to IncludeStructure.

Thu Feb 16 08:41:20 PST 2023

kadircet added inline comments.

================
Comment at: clang-tools-extra/clangd/Headers.h:167
+  // Spelling should include brackets or quotes, e.g. <foo>.
+  llvm::SmallVector<HeaderID>
+  mainFileIncludesWithSpelling(llvm::StringRef Spelling) const {
----------------
we're still returning just the `HeaderID`, the suggestion was to return `llvm::SmallVector<Inclusion*>` so that applications can work with other information available in the `Inclusion`. we also won't have any requirements around include being resolved that way. the application should figure out what to do if `HeaderID` is missing.

also can you move this function body to source file instead?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143509/new/

https://reviews.llvm.org/D143509