[PATCH] D144100: [clang] Fix a bug that allowed some overflowing octal escape sequences
Corentin Jabot via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 16 03:01:50 PST 2023
cor3ntin accepted this revision.
cor3ntin added a comment.
This revision is now accepted and ready to land.
I wonder if a better fix would be change ResultChar to be a 64 bits integer, although I think it might be over killed (ie, i'm not aware of a good use case for wanting to store values that large in a 32 bits wide char, so this looks fine.
Thanks for the fix :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144100/new/
https://reviews.llvm.org/D144100
More information about the cfe-commits
mailing list