[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

[Valentin Clement via Phabricator via cfe-commits]

clementval added a comment.

You still have style mismatch in `flang/include/flang/Tools/CLOptions.inc`. This file is likely not run through clang-format so that's why.



================
Comment at: flang/include/flang/Tools/CLOptions.inc:214
+    llvm::OptimizationLevel optLevel = defaultOptLevel,
+    bool Underscoring = true) {
   fir::addBoxedProcedurePass(pm);
----------------



================
Comment at: flang/include/flang/Tools/CLOptions.inc:233
     llvm::OptimizationLevel optLevel = defaultOptLevel,
-    bool stackArrays = false) {
+    bool stackArrays = false, bool Underscoring = true) {
   // Add default optimizer pass pipeline.
----------------



================
Comment at: flang/include/flang/Tools/CLOptions.inc:238
   // Add codegen pass pipeline.
-  fir::createDefaultFIRCodeGenPassPipeline(pm, optLevel);
+  fir::createDefaultFIRCodeGenPassPipeline(pm, optLevel, Underscoring);
 }
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140795/new/

https://reviews.llvm.org/D140795