[PATCH] D144100: [clang] Fix a bug that allowed some overflowing octal escape sequences

[Shafik Yaghmour via Phabricator via cfe-commits]

shafik added inline comments.


================
Comment at: clang/lib/Lex/LiteralSupport.cpp:266
       }
-      if (ResultChar & 0x020000000)
+      // About to shift out a digit?
+      if (ResultChar & 0xE0000000)
----------------
Maybe the comment should be more specific such as "one of the top three bits are set" or something similar.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144100/new/

https://reviews.llvm.org/D144100