[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

[Eli Friedman via Phabricator via cfe-commits]

efriedma added a comment.

If the "strictfp" attribute is based on the contents of the function body, should we recompute it when the function is instantiated, as opposed to copying it?  For example, say you have a pragma inside an "if constexpr"; should that set the strictfp attribute if it's discarded?

Otherwise, I guess updateAttrsForLateParsedTemplate makes sense.



================
Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:824
+      continue;
+    }
+
----------------
Is this necessary?  The non-delayed-parsed case seems to work correctly on trunk without any changes, so I suspect the autogenerated sema::instantiateTemplateAttribute is doing the right thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143919/new/

https://reviews.llvm.org/D143919