[PATCH] D137526: [C++20] [Modules] [NFC] Add Preprocessor methods for named modules - for ClangScanDeps (1/4)

Tue Feb 14 17:59:04 PST 2023

ChuanqiXu added a comment.

In D137526#4125578 <https://reviews.llvm.org/D137526#4125578>, @nikic wrote:

> It looks like this causes a minor compile-time regression (about 0.2% on `O0` builds): http://llvm-compile-time-tracker.com/compare.php?from=ad81d019a62d33e5d1f232844b83d3e164e4b160&to=6470706bc0ed2425704bc8c9e121a72e2d272616&stat=instructions:u
>
> I wanted to check whether this is expected (as I don't think CTMark even compiles anything in C++20 mode).

This is strange since all the codes would only work if there is an `import`. And I didn't introduce any loops so it shouldn't cause compile-time regression.

================
Comment at: clang/unittests/Lex/CMakeLists.txt:21
   clangBasic
+  clangFrontend
   clangLex
----------------
thakis wrote:
> It seems strange layering-wise that the Lex unit tests would depend on Frontend. Is there any way to prevent that dep?
I see. I'll try to look at it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137526/new/

https://reviews.llvm.org/D137526