[PATCH] D142507: [AMDGPU] Split dot7 feature

Tue Feb 14 15:15:38 PST 2023

b-sumner added a comment.

In D142507#4127382 <https://reviews.llvm.org/D142507#4127382>, @rampitec wrote:

> In D142507#4127374 <https://reviews.llvm.org/D142507#4127374>, @aaronmondal wrote:
>
>> I think unless conflicts arise creating an issue similar to this https://github.com/llvm/llvm-project/issues/60600 with the `cherry-pick` line set to this commit should be enough. (See also https://llvm.org/docs/GitHub.html).
>
> I believe it will need D142407 <https://reviews.llvm.org/D142407> to be cherry-picked as well to apply cleanly. Otherwise I do not expect conflicts. So the c-p need to go into release/16.x, right?
> Let's wait for @b-sumner first anyway, he is maintaining device-lib.

I have no objection to backporting this, but it may need to be accompanied with a device-libs patch, and I don't know where that patch would be checked in.  The ROCm-Device-Libs in github certainly doesn't have a "clang-16" branch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142507/new/

https://reviews.llvm.org/D142507