[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

Piotr Zegar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 14 09:29:31 PST 2023


ClockMan added a comment.

Thing is that same issue may happen with all other members, what about copy/move constructors defaulted in .cpp (just to speed up compilation for classes with many members).
Best thing would simply to check if all definitions are available. In that case issues would be reported only for source file that corresponds to header file with defined class.
This would also reduce amount of generated warnings for a big project that include such header with class in many places.

Other good option would be to excluded classes defined in system headers, no point to check if some boost class or std::vector got proper constructors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143851/new/

https://reviews.llvm.org/D143851



More information about the cfe-commits mailing list