[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

Tue Feb 14 07:39:10 PST 2023

pmatos marked 2 inline comments as done.
pmatos added a comment.

@aaron.ballman I have finished addressing all the concerns on this patch. Do you have any further comments?

================
Comment at: clang/lib/Sema/SemaType.cpp:7289-7290
+  QualType Pointee = Type->getPointeeType();
+  Pointee = S.Context.getAddrSpaceQualType(
+      S.Context.removeAddrSpaceQualType(Pointee), ASIdx);
+  Type = State.getAttributedType(A, Type, S.Context.getPointerType(Pointee));
----------------
aaron.ballman wrote:
> aaron.ballman wrote:
> > What happens when the user's function already has an explicitly specified address space?
> Still wondering about this as well.
We'll just be overriding the address space in this case. Although, I am not sure something like this can happen in Wasm given there's only one linear memory.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128440/new/

https://reviews.llvm.org/D128440