[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

Felipe de Azevedo Piovezan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 14 07:21:30 PST 2023


fdeazeve added a comment.

In D143921#4124533 <https://reviews.llvm.org/D143921#4124533>, @aprantl wrote:

> In D143921#4123218 <https://reviews.llvm.org/D143921#4123218>, @fdeazeve wrote:
>
>> Any testing suggestions here? I can use what we have on GH (cpp -> codegen test), but I'm not sure if there's a finer grained test we could use.
>
> I was thinking of a very small IR test similar to `llvm/test/Verifier/disubprogram-name-match-only.ll`.

Yup, good idea, this should be enough! Added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143921/new/

https://reviews.llvm.org/D143921



More information about the cfe-commits mailing list