[PATCH] D143870: [clang-format] Remove all include duplicates not only those in the same block

Fabian Keßler via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 13 13:20:59 PST 2023


Febbe added a comment.

@HazardyKnusperkeks thank you for the review, I would add another option, but I don't know a good name. I would propose a

`boolean` `IncludeDeduplicateInAllBlocks` which defaults to zero.

First an `Include`, to keep include-sorting related options together in the documentation (sorted by name not by category)
`DeduplicateInAllBlocks` self explaining name.

But `IncludeDeduplication` with the enum states `IDD_SameBlock`(default) and IDD_ALL would also an option.
The latter has the advantage, that an expansion of this option would not require the adjustment of tests.

What's your preference?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143870/new/

https://reviews.llvm.org/D143870



More information about the cfe-commits mailing list