[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 13 11:02:39 PST 2023


aaron.ballman added a reviewer: efriedma.
aaron.ballman added a comment.

Please be sure to add release notes to clang/docs/ReleaseNotes.rst

Things look reasonable to me, but it'd be nice if someone with more Windows ABI experience could take a look as well.



================
Comment at: clang/lib/CodeGen/MicrosoftCXXABI.cpp:243
+      GlobalDecl LookupGD = GD;
+      if (const CXXDestructorDecl *DD = dyn_cast<CXXDestructorDecl>(MD)) {
+        // Complete dtors take a pointer to the complete object,
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143233/new/

https://reviews.llvm.org/D143233



More information about the cfe-commits mailing list