[PATCH] D143917: [clang-tidy] Clarify branch-clone diagnostic message

DonĂ¡t Nagy via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 13 07:52:36 PST 2023


donat.nagy created this revision.
donat.nagy added reviewers: aaron.ballman, njames93, carlosgalvezp.
donat.nagy added a project: clang-tools-extra.
Herald added subscribers: gamesh411, Szelethus, dkrupp, xazax.hun.
Herald added a project: All.
donat.nagy requested review of this revision.

This simple commit inserts "body" into the message "repeated branch //body// in conditional chain". This is motivated by feedback from a confused user who (at first glance) thought that clang-tidy complained about a repeated branch //condition//.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143917

Files:
  clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp
  clang-tools-extra/test/clang-tidy/checkers/bugprone/branch-clone-if-constexpr-template.cpp
  clang-tools-extra/test/clang-tidy/checkers/bugprone/branch-clone-macro-crash.c
  clang-tools-extra/test/clang-tidy/checkers/bugprone/branch-clone.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143917.496988.patch
Type: text/x-patch
Size: 6985 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230213/28706421/attachment.bin>


More information about the cfe-commits mailing list