[PATCH] D143867: [analyzer] Fix SARIF column location assertion crash

[Balázs Benics via Phabricator via cfe-commits]

steakhal added a comment.

In D143867#4121841 <https://reviews.llvm.org/D143867#4121841>, @Scarlet1ssimo wrote:

> In D143867#4121835 <https://reviews.llvm.org/D143867#4121835>, @steakhal wrote:
>
>> Looks sensible to me.
>> Do you have a test for triggering the previous assertion?
>
> I do have prepared a test case like:
>
>   int testA(void) { return 0/0; }
>   // RUN: %clang_analyze_cc1 -analyzer-checker=core %s -analyzer-output=sarif -o - 
>
> Notice you must put the buggy code at the very first line to trigger the assertion.

The test passes on `main`. Are you sure about the reproducer?
I copy-pasted your code as-is into a test file, but `check-clang-analysis` still passes.

> Do you think it's necessary to put this test case into the test suite?

Generally, we only merge changes with tests, but I'm not the one who sets the rules.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143867/new/

https://reviews.llvm.org/D143867