[PATCH] D137527: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)
Chuanqi Xu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Feb 12 18:41:00 PST 2023
ChuanqiXu updated this revision to Diff 496821.
ChuanqiXu added a comment.
While I failed to reproduce the failure in my local environment, I found a thread-safe defect in my code. I forgot to add a Lock for `P1689::addRules`. I'd like to recommit this one and see if the bot would still complain. Thank you for reporting and reverting this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137527/new/
https://reviews.llvm.org/D137527
Files:
clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h
clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
clang/include/clang/Tooling/DependencyScanning/DependencyScanningWorker.h
clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h
clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp
clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp
clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp
clang/test/ClangScanDeps/P1689.cppm
clang/tools/clang-scan-deps/ClangScanDeps.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137527.496821.patch
Type: text/x-patch
Size: 21161 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230213/c702a059/attachment-0001.bin>
More information about the cfe-commits
mailing list