[PATCH] D142933: Add -print-multi-selection-flags argument

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 10 23:02:15 PST 2023


MaskRay added a comment.

> Add -print-multi-selection-flags argument

"option" is a better term. Since the option doesn't take an argument, "flag" applies as well.

`[Driver] Add -print-multi-selection-flags`

The summary is empty. Is that intended? We need some description what the new option does.



================
Comment at: clang/lib/Driver/ToolChain.cpp:273
+  if (SanArgs.needsAsanRt()) {
+    Result.push_back("fsanitize=address");
+  }
----------------
remove braces


================
Comment at: clang/lib/Driver/ToolChain.cpp:297
+
+  // Sort alphabetically
+  std::sort(Result.begin(), Result.end());
----------------
This function overly uses blank lines. 

```
// Sort and remove duplicates.
std::sort(Result.begin(), Result.end());
Result.erase(std::unique(Result.begin(), Result.end()), Result.end());
return Result;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142933/new/

https://reviews.llvm.org/D142933



More information about the cfe-commits mailing list