[PATCH] D142932: [NFC] Multilib YAML parsing

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

Adding new APIs is usually not considered `NFC`. Just remove the tag.



================
Comment at: clang/lib/Driver/Multilib.cpp:115
+    if (!StringRef(M.Regex).starts_with("^")) {
+      RegexString.insert(RegexString.begin(), '^');
+    }
----------------
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements


================
Comment at: clang/lib/Driver/Multilib.cpp:118
+    if (!StringRef(M.Regex).ends_with("$")) {
+      RegexString.push_back('$');
+    }
----------------
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements


================
Comment at: clang/lib/Driver/Multilib.cpp:134
+
+struct MultilibSerialization {
+  std::string Dir;
----------------
anonymous namespace


================
Comment at: clang/lib/Driver/Multilib.cpp:139
+
+struct MultilibSetSerialization {
+  std::vector<MultilibSerialization> Multilibs;
----------------
anonymous namespace


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142932/new/

https://reviews.llvm.org/D142932