[PATCH] D143768: [Clang] Add options to disable direct linking of arch tools

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 10 10:41:44 PST 2023


jhuber6 added a comment.

In D143768#4119021 <https://reviews.llvm.org/D143768#4119021>, @aaronmondal wrote:

> Does this address the case where we have HSA headers present on the system?
>
> Since this only seems to modify link time behavior, I think building with this flag would still include "hsa/hsa.h" if they were present.

Those headers are guarded behind `#ifndef DYNAMIC_CUDA`. This is how we configure it to use the `dlopen` method, see the `target_compile_definitions` line. We used to use `__has_include` but it caused buildbots to fail for Windows cross compiling.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143768/new/

https://reviews.llvm.org/D143768



More information about the cfe-commits mailing list