[PATCH] D143692: [clang][driver] Emit error when enabling emulated tls on unsupported architectures

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 10 10:19:39 PST 2023


MaskRay accepted this revision.
MaskRay added a comment.

With nits



================
Comment at: clang/test/Driver/emulated-tls.cpp:49
+// RISCV-NOT:  unsupported option '-fno-emulated-tls' for target 'riscv64-unknown-linux-android'
+// RISCV-ERROR:  unsupported option '-femulated-tls' for target 'riscv64-unknown-linux-android'
----------------
Prepend `error:`

For the `NOT` pattern, use `RISCV-NOT: error:` or change FileCheck to `FileCheck --implicit-check-not=error:`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143692/new/

https://reviews.llvm.org/D143692



More information about the cfe-commits mailing list