[PATCH] D143755: [clang-format] Add a space between an overloaded operator and '>'
Igor Kushnir via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 10 09:42:19 PST 2023
vedgy added a comment.
Hi @owenpan. Thank you for fixing this bug!
Have you noticed this paragraph in my bug report?
> I believe `clang_getTypeSpelling()`, or more likely `QualType::print()` used by it, should insert a tab character between such tokens to pretty-print compilable code. The tab character is preferable to the space character here, because the users may rely on the fact that pretty-printed binary operators are surrounded by spaces to distinguish them from angle brackets.
KDevelop parses the result of `clang_getTypeSpelling()` when libclang API is lacking. Since this recent commit <https://commits.kde.org/kdevelop/kdevelop/7b7690ce25fc150018be59309d2c82a04e43aa43> KDevelop's parsing relies on the empirical fact that only operators are surrounded by spaces to distinguish them from angle brackets. Does this revision introduce angle brackets surrounded by spaces? Can tab characters be used instead? If not, do you know how else such angle brackets can be distinguished from operators?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143755/new/
https://reviews.llvm.org/D143755
More information about the cfe-commits
mailing list