[PATCH] D143638: [clangd] Move function body to out-of-line: unnamed class method incorrect moving
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 10 05:11:42 PST 2023
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/unittests/tweaks/DefineOutlineTests.cpp:89
+ // Not available on methods of unnamed classes.
+ EXPECT_UNAVAILABLE(R"cpp(
+ struct Foo {
----------------
nit: i think you can group all these 3 tests.
```
// Not available if any of the parent context is unnamed, as we can't spell it.
EXPECT_UNAVAILABLE(R"cpp(
struct Foo {
struct {
void b^ar() {}
struct Baz { void b^ar() {} };
} Bar;
};
namespace {
struct Foo { void f^oo() {} };
}
)cpp");
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143638/new/
https://reviews.llvm.org/D143638
More information about the cfe-commits
mailing list