[clang] dd380f9 - [NFC] Remove the unused parameter introduced in e135476
Chuanqi Xu via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 10 00:04:22 PST 2023
Author: Chuanqi Xu
Date: 2023-02-10T16:03:29+08:00
New Revision: dd380f9243dec95744a43ff73723e85ad77abbdb
URL: https://github.com/llvm/llvm-project/commit/dd380f9243dec95744a43ff73723e85ad77abbdb
DIFF: https://github.com/llvm/llvm-project/commit/dd380f9243dec95744a43ff73723e85ad77abbdb.diff
LOG: [NFC] Remove the unused parameter introduced in e135476
I introduced an unused parameter due to an oversight during rebasing.
Now the patch removes the parameter.
Added:
Modified:
clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp
clang/tools/clang-scan-deps/ClangScanDeps.cpp
Removed:
################################################################################
diff --git a/clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h b/clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
index 4eac56ec81b4..961e383b1096 100644
--- a/clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
+++ b/clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
@@ -106,8 +106,7 @@ class DependencyScanningTool {
llvm::Expected<P1689Rule>
getP1689ModuleDependencyFile(
const clang::tooling::CompileCommand &Command, StringRef CWD,
- std::string &MakeformatOutput, std::string &MakeformatOutputPath,
- std::optional<StringRef> ModuleName = std::nullopt);
+ std::string &MakeformatOutput, std::string &MakeformatOutputPath);
/// Given a Clang driver command-line for a translation unit, gather the
/// modular dependencies and return the information needed for explicit build.
diff --git a/clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp b/clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp
index b336e2f28e01..b5e336bc704c 100644
--- a/clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp
+++ b/clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp
@@ -92,8 +92,7 @@ llvm::Expected<std::string> DependencyScanningTool::getDependencyFile(
llvm::Expected<P1689Rule> DependencyScanningTool::getP1689ModuleDependencyFile(
const CompileCommand &Command, StringRef CWD,
- std::string &MakeformatOutput, std::string &MakeformatOutputPath,
- std::optional<StringRef> ModuleName) {
+ std::string &MakeformatOutput, std::string &MakeformatOutputPath) {
class P1689ModuleDependencyPrinterConsumer
: public MakeDependencyPrinterConsumer {
public:
diff --git a/clang/tools/clang-scan-deps/ClangScanDeps.cpp b/clang/tools/clang-scan-deps/ClangScanDeps.cpp
index fc2ade955a57..4cfb857c5b3b 100644
--- a/clang/tools/clang-scan-deps/ClangScanDeps.cpp
+++ b/clang/tools/clang-scan-deps/ClangScanDeps.cpp
@@ -833,8 +833,7 @@ int main(int argc, const char **argv) {
std::string MakeformatOutput;
auto MaybeRule = WorkerTools[I]->getP1689ModuleDependencyFile(
- *Input, CWD, MakeformatOutput, MakeformatOutputPath,
- MaybeModuleName);
+ *Input, CWD, MakeformatOutput, MakeformatOutputPath);
HadErrors =
handleP1689DependencyToolResult(Filename, MaybeRule, PD, Errs);
More information about the cfe-commits
mailing list