[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

Amara Emerson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 9 15:06:22 PST 2023


aemerson added a comment.

In D143624#4116546 <https://reviews.llvm.org/D143624#4116546>, @aeubanks wrote:

> Had a chat offline with @mtrofin, wanted to be clear for future purposes that we do need the separate AlwaysInliner pass because it's used in -O0 and constructing a call graph there is non-trivial in terms of compile time. Originally the mandatory mode of the normal inliner was added to maybe remove the separate AlwaysInliner pass in the future, but that's not going to happen because of what I just said. Given that, we can eventually remove the mandatory mode of the normal inliner after this patch goes through. So this patch should also make `mandatory-inlining-first` false by default, then we remove it in a separate patch.

Ok, sounds good. I'll make the changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143624/new/

https://reviews.llvm.org/D143624



More information about the cfe-commits mailing list