[PATCH] D49723: [OpenCL] Check for invalid kernel arguments in array types

[Ayal Zaks via Phabricator via cfe-commits]

Ayal added a comment.
Herald added a subscriber: Naghasan.
Herald added a project: All.

In D49723#1178186 <https://reviews.llvm.org/D49723#1178186>, @asavonic wrote:

> In D49723#1178127 <https://reviews.llvm.org/D49723#1178127>, @Anastasia wrote:
>
>> In D49723#1174837 <https://reviews.llvm.org/D49723#1174837>, @asavonic wrote:
>>
>>> In D49723#1173352 <https://reviews.llvm.org/D49723#1173352>, @Anastasia wrote:
>>>
>>>> Btw, has this restriction been removed from CL 2.0?
>>>
>>> No, it applies for CL2.0 as well.
>>
>> It seems however the restriction on pointer to pointer was removed (see s6.9.a last item) in CL2.0.
>
> Right, and it seems that pointers in struct arguments should also be legal in CL2.0.
> I'll submit another patch to remove this check for CL2.0.

This is admittedly a couple of years old by now, but wonder about that other intended patch - Clang still seems to consider pointers in struct arguments to be illegal in CL2.0 (and CL3.0) - please see https://godbolt.org/z/E87z66h1d


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49723/new/

https://reviews.llvm.org/D49723