[PATCH] D143587: [Docs] Multilib design

[Amilendra Kodithuwakku via Phabricator via cfe-commits]

amilendra added a comment.

Thanks for the design docs. At a high-level this gives a good summary on what you intend the multilib feature to do. Couple of suggestions.



================
Comment at: clang/docs/Multilib.rst:86-89
+   a match.
+   If more than one variant matches then a toolchain may opt to either use only
+   the *last* matching multilib variant, or may use all matching variants,
+   thereby layering them.
----------------
Would it be possible to give more details on how the toolchain makes this choice?


================
Comment at: clang/docs/Multilib.rst:97
+
+Multilib via configuration file shall be considered an experimental feature
+until LLVM 18, at which point ``-print-multi-selection-flags-experimental``
----------------
Would it be worth to also add a flag to activate/deactivate the multilib feature for the duration that it is experimental?
IIUC, a similar mechanism was used before switching to a new pass manager.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143587/new/

https://reviews.llvm.org/D143587