[PATCH] D143509: Move the BySpelling map to IncludeStructure.
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 9 00:39:35 PST 2023
kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/Headers.h:164
+ llvm::StringMap<llvm::SmallVector<IncludeStructure::HeaderID>>
+ buildMainFileIncludesBySpelling() const {
+ llvm::StringMap<llvm::SmallVector<IncludeStructure::HeaderID>> BySpelling;
----------------
instead of building this on-demand, what about building it as we're collecting directives around https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clangd/Headers.cpp#L52 ?
afterwards we can just have a lookup function exposed here, that returns an `ArrayRef<HeaderID>` ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143509/new/
https://reviews.llvm.org/D143509
More information about the cfe-commits
mailing list