[PATCH] D143446: [clang][deps] Ensure module invocation can be serialized

[Ben Langmuir via Phabricator via cfe-commits]

benlangmuir marked 3 inline comments as done.
benlangmuir added inline comments.


================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:658
+#endif
+  if (RoundTripArgs.getNumOccurrences() ? RoundTripArgs : DoRoundTripDefault)
+    if (FD.roundTripCommands(llvm::errs()))
----------------
jansvoboda11 wrote:
> The call to `getNumOccurrences()` is a bit odd. Can you drop that if you add `llvm::cl::init(false)` to the option definition?
I did this so that you can do `-round-trip-args=false` even if the default is true.  But I simplified it by doing `lvm::cl::init(DoRoundTripDefault)` instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143446/new/

https://reviews.llvm.org/D143446