[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

Wed Feb 8 12:30:56 PST 2023

owenpan added inline comments.

================
Comment at: clang/lib/Format/TokenAnnotator.cpp:3884
   if (Style.isCpp()) {
+    if (Right.is(tok::period) && Left.is(tok::numeric_constant))
+      return true;
----------------
HazardyKnusperkeks wrote:
> Add a comment what that is? Without the bug report I'd not know what that sequence would be.
I could do that, but the github issue is linked in the summary above and will be in the commit message. In general, I don't like unnecessary comments littered in the source. They can become outdated, out of place, misleading, and even wrong. How about giving an example as shown above?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143546/new/

https://reviews.llvm.org/D143546