[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

Wed Feb 8 12:02:48 PST 2023

owenpan added a comment.

In D141098#4111890 <https://reviews.llvm.org/D141098#4111890>, @sunho wrote:

> I think it makes more sense to use stable version of clang-format for that purpose but I'm not in a postion to decide as I don't work with format. Can you change the script to use latest clang-format for format codebase and revert this patch in the meantime?

We don't want to change git-clang-format on a whim. If you think there is an issue, please file a bug report.

> Currently, all patches that touch format part will see format verifiaction ci faliure with this patch.

That's not true. We've had several clang-format commits since this patch landed. We don't want to defeat the purpose (or delay the effect) of this patch and should let the premerge check fail if the patch to the current format source is not formatted by the latest clang-format.

This is the only buildbot reported to be impacted by this patch. Can we fix the bot instead? In addition to using `--binary` of git-clang-format as I suggested before, another way would be to format a patch to files outside the format directory?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141098/new/

https://reviews.llvm.org/D141098