[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping
Ben Langmuir via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 8 10:24:45 PST 2023
benlangmuir added a comment.
+1 for determinism. Okay I spent some time trying to understand how this code is used and the non-virtual paths make some sense now. I am a bit skeptical about this on-disk-hash-table by filepath but that's separate from this patch.
================
Comment at: clang/lib/Serialization/ASTWriter.cpp:175
-
- if (FilesByUID.size() > HS.header_file_size())
- FilesByUID.resize(HS.header_file_size());
----------------
I think you can remove `header_file_size`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143414/new/
https://reviews.llvm.org/D143414
More information about the cfe-commits
mailing list