[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

Dominik Adamski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 8 08:10:42 PST 2023


domada added a comment.

In D141910#4112164 <https://reviews.llvm.org/D141910#4112164>, @tschuett wrote:

> For AArch64 the default alignment is 0? I would have expected 128.

The refactored function `TargetInfo::getSimdDefaultAlign` is used only for calculation of default alignment for `#pragma omp simd aligned(A)`. If user does not specify any alignment in OpenMP simd pragma, then we will assume that the alignment of `A` is equal to 128 for PPC, WebAssembly or for some X86 targets and we insert proper assumptions into LLVM IR (please refer to: clang test for more details <https://github.com/llvm/llvm-project/blob/main/clang/test/OpenMP/simd_metadata.c>. For other targets like AArch64 we don't insert any assumptions into LLVM IR code.

I just refactored the code and I return the same values as previous function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141910/new/

https://reviews.llvm.org/D141910



More information about the cfe-commits mailing list