[PATCH] D143560: clang-format.el: fix warnings

[Philipp via Phabricator via cfe-commits]

phst requested changes to this revision.
phst added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/tools/clang-format/clang-format.el:70
           (cl-case (xml-node-name node)
-            ('replacement
+            ((replacement quote)
              (let* ((offset (xml-get-attribute-or-nil node 'offset))
----------------
what's the change here?


================
Comment at: clang/tools/clang-format/clang-format.el:80
                (push (list offset length text) replacements)))
-            ('cursor
+            ((cursor quote)
              (setq cursor (string-to-number text)))))))
----------------
same here, what is being changed?


================
Comment at: clang/tools/clang-format/clang-format.el:85
                              (lambda (a b)
                                (or (> (car a) (car b))
                                    (and (= (car a) (car b))
----------------
The intention here is that this should be just `replacement' since I'm pretty sure we don't have XML tags like <quote>


================
Comment at: clang/tools/clang-format/clang-format.el:96
                                                  'utf-8-unix)))
     (goto-char start)
     (delete-region start end)
----------------
same here, AIUI this should just be `quote'


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143560/new/

https://reviews.llvm.org/D143560