[PATCH] D142932: [NFC] Multilib YAML parsing

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 7 21:23:17 PST 2023


phosek added a comment.

Do you know if regular expressions are necessary to cover the existing use cases? In our experience, while regular expressions are powerful, they also tend to be error prone and more difficult to reason about. Would glob patterns that are implemented by https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/Support/GlobPattern.h be sufficient?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142932/new/

https://reviews.llvm.org/D142932



More information about the cfe-commits mailing list