[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping
Ben Langmuir via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 7 08:36:45 PST 2023
benlangmuir added a comment.
> This should allow the path serialization of input files to use the paths used when looking up a file entry, instead of the last reference.
Isn't this at odds with not having the VFS-mapped paths?
It's not obvious to me why we want these specific semantics. Elsewhere we have tried to preserve the virtual paths as well as the vfsoverlay files needed to interpret them. Is there a reason the current approach is better? I feel like there may be context here I'm lacking
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143414/new/
https://reviews.llvm.org/D143414
More information about the cfe-commits
mailing list